mapbox / mapbox/mapbox-navigation-android
Branch protection on main not adhering to best practices
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 651
- Forks
- 321
- PR merge metrics
- No merged PRs in 30d
Description
:wave: Hey there! It's [Changebot](https://github.com/mapbox/changebot), and I help repositories follow our [engineering](https://github.com/mapbox/engineering) best practices. My magic wand found some things I wanted to highlight for your review:
Item | Current status | Best practice guidelines
--- | --- | ---
main branch protection: Dismiss stale pull request approvals when new commits are pushed | Unchecked | Checked
main branch protection: Restrict who can dismiss pull request reviews | Unchecked | Checked
main branch protection: Require branches to be up to date before merging | Unchecked | Checked
main branch protection: Restrict who can push to this branch | Unchecked | Checked
Can you take a look at these best practices and make any adjustments if needed?
Please tag `@mapbox/security-and-compliance` on this issue if you have any questions
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the main branch protection settings against the four best-practice items listed in the issue. Check the repository's engineering guidelines and tag @mapbox/security-and-compliance if clarification is needed; done means the applicable main-branch protections match those guidelines.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github
- Domain
- devops
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100