mapbox / mapbox/mapbox-navigation-android
Add ability to remove SharedApp state controllers
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 651
- Forks
- 321
- PR merge metrics
- No merged PRs in 30d
Description
[The `SharedApp` has a setup](https://github.com/mapbox/mapbox-navigation-android/blob/de3031d855da3817a9b88aefb04cd5a2496d018d/libnavui-app/src/main/java/com/mapbox/navigation/ui/app/internal/SharedApp.kt#L53) but does not have any way to remove the state controllers.
When we have a lot of examples https://github.com/mapbox/mapbox-navigation-android-examples/issues/128
We also want to be able to clean up all the state from any examples.
Aside from development, I'm thinking it is best to be able to clean it up anyways. Many applications will include navigation as feature and do not want to have lingering subscriptions.
cc: @tomaszrybakiewicz @abhishek1508
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the SharedApp setup in libnavui-app/src/main/java/com/mapbox/navigation/ui/app/internal/SharedApp.kt, linked in the issue, and trace how its state controllers are created and retained. Define what cleanup must cover for the examples and applications described in the issue, then verify that removing the controllers leaves no lingering subscriptions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100