mapbox / mapbox/mapbox-navigation-android
Disable the flaky test and make instrumentation-tests build required
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 651
- Forks
- 321
- PR merge metrics
- No merged PRs in 30d
Description
There is one flaky instrumentation test, described here: https://github.com/mapbox/mapbox-navigation-android/issues/5931.
Because of it the instrumentation-tests CI build is optional. And some real failure can be easily missed since the build is red quite often. In order to avoid merging PRs that break instrumentation tests we could do the following:
1. Temporarily disable `RouteRefreshTest#routeRefreshesWorksAfterSettingsNewRoutes`;
2. Make the instrumentation-tests build required;
3. Enable `RouteRefreshTest#routeRefreshesWorksAfterSettingsNewRoutes` after fix (should probably add this point to the mentioned ticket).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate RouteRefreshTest#routeRefreshesWorksAfterSettingsNewRoutes and the CI configuration for the instrumentation-tests build. Disable the named test, make that build required, and record that the test should be re-enabled after issue 5931 is fixed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- ci-cd, testing
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100