mapbox / mapbox/mapbox-navigation-android
Revise route line layer instrumentation tests
@cafesilencio is already working on this.
Since Jun 14, 2022.
- Dominant language
- Kotlin
- Stars
- 651
- Forks
- 321
- PR merge metrics
- No merged PRs in 30d
Description
Recently some refactoring work was done on the way the route line related layers are managed. Some tests were added that rely on timers in order to let the map perform its work before checking the results. This isn't an ideal solution, a better suggestion was made here: https://github.com/mapbox/mapbox-navigation-android/pull/5859#discussion_r886799640 however at the time that suggestion wasn't working. It was necessary to move forward with the work in the PR in spite of this but this issue ticket is meant to track revisiting the issue and investigating a better solution for the tests.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.