mapbox / mapbox/mapbox-navigation-android
MapboxSpeedLimitView empty does not show after being removed
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 651
- Forks
- 321
- PR merge metrics
- No merged PRs in 30d
Description
Considering this a minor issue. But there does not seem to be a way to restore the previous state for the speed limit view. This becomes apparent when attempting to remove/add the view at runtime.
### Steps to trigger behavior
1. Create a view with MapboxSpeedLimitView
2. Get a speed limit, notice valid speed limit
3. Go to location without a speed limit, notice `--` empty speed limit
4. Swap views
### Expected behavior
The speed limit view with `--` should re-appear. Or there should be a way to restore the state
### Actual behavior
https://user-images.githubusercontent.com/3021882/155822243-22cc8943-6463-45ae-b6cd-812dde7fad54.mp4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the four listed steps with MapboxSpeedLimitView, including swapping views after showing a valid limit and then `--`. Trace how the view handles removal and re-addition; done means the empty `--` state reappears after the swap or a supported way to restore it is provided.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100