mapbox / mapbox/mapbox-navigation-android
Directions Session: migration to Native API instead Router
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 651
- Forks
- 321
- PR merge metrics
- No merged PRs in 30d
Description
SDK's `DirectionsSession` has to migrate to hold `NativeNavigator` instead of `Router`. This way any route requests will be processed in NN by default.
**Blocker**: For now `DirectionsSession` is used by SDK's [MapboxRerouteController](https://github.com/mapbox/mapbox-navigation-android/blob/b654560e5d1ea8fb94e63b1014468f3dce08b5bc/libnavigation-core/src/main/java/com/mapbox/navigation/core/reroute/MapboxRerouteController.kt), which required refresh route API. When Refresh Route will be migrated to NN, migration should be unblocked.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating DirectionsSession and reading libnavigation-core/src/main/java/com/mapbox/navigation/core/reroute/MapboxRerouteController.kt, especially its refresh route usage. Check whether Refresh Route has migrated to NativeNavigator; the work is done when DirectionsSession can hold NativeNavigator and route requests use it by default without breaking rerouting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin
- Domain
- mobile
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100