mapbox / mapbox/mapbox-navigation-android
current leg index incorrect after reroute for multi-leg routes
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 651
- Forks
- 321
- PR merge metrics
- No merged PRs in 30d
Description
Capturing from @tkvalentine56 in https://github.com/mapbox/mapbox-navigation-android/pull/4999#issuecomment-953972363:
I have a 25 waypoint route which navigates fine until an OFF ROUTE state is experienced. When the route progress event state changes back to TRACKING the current leg index is always zero and the route leg count increments by one. I am then directed to continue navigation to the the first point on the route (which is now the additional point added which appears to be the original first point). This ultimately produces a navigation experience which is confusing, illogical and un-useful.
What I expect after transitioning from OFF ROUTE to TRACKING is that the current leg index be that of the next unarrived waypoint on the route and the route leg count to remain the same.
Here is log output from a navigation run today. Notes are embedded as well as the route progress event associated route directions json.
[route_directions_log_output.txt](https://github.com/mapbox/mapbox-navigation-android/files/7455820/route_directions_log_output.txt)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with route_directions_log_output.txt and the route progress events described in the report, then trace how OFF ROUTE transitions back to TRACKING update the current leg index and route leg count. Done means a multi-leg route preserves its leg count and resumes at the next unarrived waypoint after rerouting, with regression coverage for the reported case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin
- Domain
- mobile-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100