mapbox / mapbox/mapbox-navigation-android
Relax logs in ViewportDataSource processor or filter out more cases
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 651
- Forks
- 321
- PR merge metrics
- No merged PRs in 30d
Description
In https://github.com/mapbox/mapbox-navigation-android/blob/5e53d2355afcf459b3da1c116e7aa77db4ca44c6/libnavui-maps/src/main/java/com/mapbox/navigation/ui/maps/camera/data/ViewportDataSourceProcessor.kt#L200-L202
we're catching and logging failure in line slicing which actually are often valid use cases (for example after we reached the destination).
We should either if-check this cases before trying to slice the line or relax the log because currently it creates a little bit of confusion.
cc @dudeuter @abhishek1508
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in libnavui-maps/src/main/java/com/mapbox/navigation/ui/maps/camera/data/ViewportDataSourceProcessor.kt around lines 200-202 and inspect the line-slicing failure handling. Check how valid cases such as reaching the destination are logged, then choose whether to filter those cases or relax the failure log. Done means valid use cases no longer produce confusing failure messages.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100