mapbox / mapbox/mapbox-navigation-android

Add abilty to upload history files to circleci artifacts

Open
#4,506 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

jira-sync-complete
Dominant language
Kotlin
Stars
651
Forks
321
PR merge metrics
No merged PRs in 30d

Description

~In the instrumentation tests we could add a `MapboxHistoryTestRule`~ A TestWatcher creates lifecycle issues with `MapboxNavigation`. Update to a test object, `TestMapboxHistoryRecorder` .

That test rule can save the history files from any test or benchmark. I think the file will need to be stored in external storage. That way we can move upload it to artifacts. Similar solution has been made for mobile-metrics.

Specifically looking to do this to help us solve this one https://github.com/mapbox/mapbox-navigation-android/pull/4419

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the instrumentation tests and the proposed MapboxHistoryTestRule/TestWatcher approach, then read the TestMapboxHistoryRecorder idea and the related mobile-metrics solution. Inspect pull request #4419 for the history files this should support. Done means tests and benchmarks can save history files in a form that CircleCI can upload as artifacts.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
ci-cd, mobile-dev, testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.