mapbox / mapbox/mapbox-navigation-android

[Mapbox Navigation v2] Crash on reroute

Open
#4,179 56 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug Core
Dominant language
Kotlin
Stars
651
Forks
321
PR merge metrics
No merged PRs in 30d

Description

**Android API:** 30
**Mapbox Navigation SDK version:** 2.0.0-beta2

### Steps to trigger behavior

1. Trigger a reroute by going off course (I'm running a mock location app on my phone)

### Expected behavior

Reroute should be successful

### Actual behavior

App crashes while trying to reroute

### Stacktraces (this has happened a couple of times this morning)

```
2021-03-25 11:51:52.530 19397-19397/com.XXXXX.YYYYY E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.XXXXX.YYYYY, PID: 19397
java.lang.IllegalArgumentException: Requested element count -1 is less than zero.
at kotlin.collections.CollectionsKt___CollectionsKt.drop(_Collections.kt:650)
at com.mapbox.navigation.core.routeoptions.MapboxRouteOptionsUpdater.update(MapboxRouteOptionsUpdater.kt:66)
at com.mapbox.navigation.core.reroute.MapboxRerouteController.reroute(MapboxRerouteController.kt:50)
at com.mapbox.navigation.core.MapboxNavigation.reroute(MapboxNavigation.kt:779)
at com.mapbox.navigation.core.MapboxNavigation.access$reroute(MapboxNavigation.kt:133)
at com.mapbox.navigation.core.MapboxNavigation$createInternalOffRouteObserver$1.onOffRouteStateChanged(MapboxNavigation.kt:773)
at com.mapbox.navigation.core.trip.session.MapboxTripSession.setOffRoute(MapboxTripSession.kt:142)
at com.mapbox.navigation.core.trip.session.MapboxTripSession.access$setOffRoute$p(MapboxTripSession.kt:56)
at com.mapbox.navigation.core.trip.session.MapboxTripSession$updateDataFromNavigatorStatus$updateNavigatorStatusDataJob$1.invokeSuspend(MapboxTripSession.kt:529)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
at android.os.Handler.handleCallback(Handler.java:938)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:246)
at android.app.ActivityThread.main(ActivityThread.java:8506)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:602)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1130)
```

```
2021-03-25 11:20:15.120 7692-7692/com.XXXXX.YYYYY E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.XXXXX.YYYYY, PID: 7692
java.lang.IllegalArgumentException: Requested element count -1 is less than zero.
at kotlin.collections.CollectionsKt___CollectionsKt.drop(_Collections.kt:650)
at com.mapbox.navigation.core.routeoptions.MapboxRouteOptionsUpdater.update(MapboxRouteOptionsUpdater.kt:66)
at com.mapbox.navigation.core.reroute.MapboxRerouteController.reroute(MapboxRerouteController.kt:50)
at com.mapbox.navigation.core.MapboxNavigation.reroute(MapboxNavigation.kt:779)
at com.mapbox.navigation.core.MapboxNavigation.access$reroute(MapboxNavigation.kt:133)
at com.mapbox.navigation.core.MapboxNavigation$createInternalOffRouteObserver$1.onOffRouteStateChanged(MapboxNavigation.kt:773)
at com.mapbox.navigation.core.trip.session.MapboxTripSession.setOffRoute(MapboxTripSession.kt:142)
at com.mapbox.navigation.core.trip.session.MapboxTripSession.access$setOffRoute$p(MapboxTripSession.kt:56)
at com.mapbox.navigation.core.trip.session.MapboxTripSession$updateDataFromNavigatorStatus$updateNavigatorStatusDataJob$1.invokeSuspend(MapboxTripSession.kt:529)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
at android.os.Handler.handleCallback(Handler.java:938)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:246)
at android.app.ActivityThread.main(ActivityThread.java:8506)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:602)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1130)

```

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with MapboxRouteOptionsUpdater.kt at line 66, then trace the reroute path through MapboxRerouteController.kt and MapboxNavigation.kt. Reproduce by going off course with a mock location app on Android API 30 using Navigation SDK 2.0.0-beta2. Done means rerouting completes successfully without the IllegalArgumentException crash.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.