mapbox / mapbox/mapbox-navigation-android
FeedbackArrivalFragment leaks activity contents on recreation
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 651
- Forks
- 321
- PR merge metrics
- No merged PRs in 30d
Description
Refs https://github.com/mapbox/mapbox-navigation-android/pull/3758#issuecomment-733991877.
When used with `NavigationView` the `FeedbackArrivalFragment` leaks the contents of the activity on recreation, most likely tied to the feedback flow listener which is part of the `NavigationView`'s `ViewModel` but is kept by the recycler in the feedback fragment.
cc @Guardiola31337
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with FeedbackArrivalFragment and the feedback flow listener in NavigationView's ViewModel, then inspect how the feedback fragment's recycler retains that listener across activity recreation. Reproduce the issue by recreating the activity and verify that the old activity contents are no longer retained after the feedback flow is dismissed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100