mapbox / mapbox/mapbox-navigation-android

Feedback button hide not working as espected

Open
#3,792 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug jira-sync-complete UI
Dominant language
Kotlin
Stars
651
Forks
321
PR merge metrics
No merged PRs in 30d

Description

**Android API:** 30
**Mapbox Navigation SDK version:** com.mapbox.navigation:ui:1.1.2 & com.mapbox.mapboxsdk:mapbox-sdk-services:5.7.0

### Steps to trigger behavior

Use `mapboxNavigationView.retrieveFeedbackButton().hide()`

### Expected behavior

Only the feedback button disappears

### Actual behavior

The feedback disappears. But the recenter button disappears also...

![2020-11-18 15 18 30](https://user-images.githubusercontent.com/23097192/99541886-a9d21600-29b1-11eb-9a2d-c04db16d48fb.jpg)

### My fix

If I use `requireView().findViewById(R.id.feedbackFab).visibility = View.GONE` the recenter button is available

![2020-11-18 15 18 24](https://user-images.githubusercontent.com/23097192/99542370-4694b380-29b2-11eb-8e69-9b685ab0d2c3.jpg)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue at mapboxNavigationView.retrieveFeedbackButton().hide() with Android API 30 and the reported SDK versions. Compare that behavior with hiding R.id.feedbackFab directly, and consider the issue done when only the feedback button disappears while the recenter button remains available.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.