mapbox / mapbox/mapbox-navigation-android

Trip notification has strange ripple effect

Open
#3,532 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

UI
Dominant language
Kotlin
Stars
651
Forks
321
PR merge metrics
No merged PRs in 30d

Description

**Mapbox Navigation SDK version:** 1.0.0-rc.7

### Steps to trigger behavior

1. Open an app
2. Start trip session
3. Click on the notification near a "stop session" button but not the button.

### Expected behavior
Ripple effect covers all parts of the notification

### Actual behavior
Ripple effect is visible only at the bottom and at the top of the notification.

P.S. On some phones (Huawei Honor 10) there is a difference in colors of notification, i.e. "Free drive" text has a navy blue background, but "stop session" has a little bit lighter one.

![trip-notification](https://user-images.githubusercontent.com/17500412/92101372-b2b93f80-ede5-11ea-8f93-ef30fb5ad7aa.gif)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by starting a trip session and tapping the trip notification near, but not on, the stop-session button. Inspect the trip notification entry point and compare the ripple bounds and notification colors with the expected behavior; done means the ripple covers the full notification consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
design, mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.