mapbox / mapbox/mapbox-navigation-android

Drop-in UI quick distance flash (max value) before the first valid RouteProgress update

Open
#3,461 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Kotlin
Stars
651
Forks
321
PR merge metrics
No merged PRs in 30d

Description

It seems that https://github.com/mapbox/mapbox-navigation-android/pull/3413 didn't fully fix the flash / max value issue we were seeing so it should be something else. Apparently something NN related. We only bumped to `18.0.3` recently in https://github.com/mapbox/mapbox-navigation-android/pull/3444 but that shouldn't affect this as the only change that `18.0.3` brought was unrelated to this, right @LukasPaczos @mskurydin @SiarheiFedartsou? We should try reproducing using `18.0.2` to confirm it.

**Android API:** Nexus 5 Android version `6.0.1`
**Mapbox Navigation SDK version:** `master`

### Steps to trigger behavior

1. Start mock location app
2. Run `NavigationViewActivity` with simulation disabled (`optionsBuilder.shouldSimulateRoute(false)`
2.1. Replace https://github.com/mapbox/mapbox-navigation-android/blob/9c4759302f9a8271f9c78080471a38e9d43bdc4e/examples/src/main/java/com/mapbox/navigation/examples/ui/NavigationViewActivity.kt#L133 with a nearby route for easier testing and for test re-routes
3. Quick flash (max value) before the first valid distance / `RouteProgress` update

### Expected behavior

No flash, nothing is displayed if the status is `INVALID`

### Actual behavior

Quick flash (max value) before the first valid distance / `RouteProgress` update 👀

![drop_in_ui_max_value_flash_at_startup](https://user-images.githubusercontent.com/1668582/90575232-f7f43500-e188-11ea-9579-8436d70d613c.png)

cc @LukasPaczos @langsmith @abhishek1508 @mskurydin @SiarheiFedartsou

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the reproduction steps and NavigationViewActivity.kt at the referenced line, using a nearby route and simulation disabled. Reproduce on SDK versions 18.0.2 and 18.0.3 to check whether the behavior differs, then trace the first distance and RouteProgress updates. Done means no maximum-value flash appears before a valid update when status is INVALID.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.