mapbox / mapbox/mapbox-navigation-android

Components not updated when changing the language on the fly while navigating

Open
#1,190 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Kotlin
Stars
651
Forks
321
PR merge metrics
No merged PRs in 30d

Description

When changing the language of the device (`Locale`) on the fly while navigating some components are not updated properly 👀

![change_locale_on_the_fly](https://user-images.githubusercontent.com/1668582/43708767-7f50d2f0-996b-11e8-9daf-c226302c18b5.gif)

The banner instructions are updated partially - only `ft` gets localized to `pie` but `mi` and the text of the instructions (e.g. `Turn left` or `You will arrive`) stay the same 🇬🇧

Also a new session is launched when foregrounding the app (not desired). Note the language changed when clicking on the `END NAVIGATION` button (a new notification is created) ☝️
After doing this you're unable to close the second session (only _Force closing_ the app from the app settings).
This is noticeable too because voice instructions are voiced twice.

After changing the language the voice instructions are still voiced in 🇬🇧 instead of 🇪🇸 (even after closing the first session as commented above).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported locale change while navigating, including foregrounding the app and ending navigation. Trace navigation session and notification lifecycle plus banner and voice instruction localization; done means all visible and spoken instructions use the new locale without duplicate sessions or an uncloseable second session.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.