mapbox / mapbox/mapbox-maps-ios
Unify SourceQueryOptions and querySourceFeatures
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 601
- Forks
- 196
- PR merge metrics
- No merged PRs in 30d
Description
## New Feature
SourceQueryOptions has 2 property sources and filter. It will be good if we can have expression as a filter like in RenderedQueryOptions. Right now SourceQueryOptions accepts only raw filters like `filter: ["==", "id", "someId"]`.
Another thing is that SourceQueryOptions is used for method querySourceFeatures. In this scenario we duplicated sourceId
querySourceFeatures accept one sourceId
SourceQueryOptions has a property with an array of sourceIds
## Why
Unify and simplify
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate SourceQueryOptions, querySourceFeatures, and RenderedQueryOptions in the Swift iOS SDK, then compare their filter and source identifier APIs. Done means the query options support expression filters consistently and querySourceFeatures no longer duplicates sourceId; confirm the affected public API usages before making changes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- api, mobile-dev
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100