mapbox / mapbox/mapbox-maps-ios
localizeLabels() doesn't work for Standard & Satellite Map Styles
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 601
- Forks
- 196
- PR merge metrics
- No merged PRs in 30d
Description
## Environment
- Xcode version: 16.0
- iOS version: 17.0
- Devices affected: Tested on iPhone 15 & iPhone 13 Pro
- Maps SDK Version: 11.6.0
## Observed behavior and steps to reproduce
Calling `localizeLabels()` does not localize labels for standard and new satellite map style. Does however work for custom map styles + traffic map style
## Expected behavior
Calling `localizeLabels()` should localize labels for all map styles
## Notes / preliminary analysis
internal func `convertExpressionForLocalization` called as part of `localizeLabels()` returns nil
## Additional links and references
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue on the listed iPhone and iOS versions with standard, satellite, custom, and traffic map styles, then trace localizeLabels() into convertExpressionForLocalization. Check why convertExpressionForLocalization returns nil for standard and satellite styles; done means labels are localized across all four styles without regressing the styles that already work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, swift
- Domain
- mobile-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100