mapbox / mapbox/mapbox-maps-ios
Bug in AttributionDialogManager when tapping the InfoButtonOrnament
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 601
- Forks
- 196
- PR merge metrics
- No merged PRs in 30d
Description
Environment
- Xcode version: 14.3
- iOS version: 16.4
- Devices affected: all
- Maps SDK Version: 10.14 (also tried 10.15 release candidate)
Observed behavior and steps to reproduce
When tapping on the info button, next to the mapbox logo, it "hangs" and doesn't display the info properly with unexpected behavior, like just displaying the alert when switching to another tab.
https://github.com/mapbox/mapbox-maps-ios/assets/9827865/e9d8c3f4-ba01-4148-b43e-6a01fa84db82
Expected behavior
Alert controller should be displayed as expected after tapping the info button.
Notes
All of the related classes that are involved are internal so it's not possible to override or change anything to fix on client side
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the InfoButtonOrnament tap on iOS 16.4 with Maps SDK 10.14 or 10.15, then inspect AttributionDialogManager and the related internal classes. Done means the alert controller appears immediately and consistently after tapping the info button, without waiting for a tab switch.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, swift
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100