mapbox / mapbox/mapbox-maps-ios
Point for location outside of screen bounds
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 601
- Forks
- 196
- PR merge metrics
- No merged PRs in 30d
Description
New Feature
A change was made that prevents points from being calculated by location if the position is out of the bounds of the view.
https://github.com/mapbox/mapbox-maps-ios/commit/1ae43c46b8fa8cbffc344fea261732cd5a2b5901
There are times when locations are still needed outside the bounds of a view for when elements are drawn that bridge the on/off screen space.
The existing function can remain but a separate function is needed the doesn't have the same bound restrictions. Or any publicly accessible location to point conversion that references the underlying map.
Why
We cannot upgrade our integration of mapbox because this causes a regression. We need to be able to calculate positions of off screen elements to correctly draw bridging elements on top of the map.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing commit 1ae43c46b8fa8cbffc344fea261732cd5a2b5901 and the existing location-to-point conversion API. Determine where the current view-bounds restriction is applied and how a publicly accessible conversion can reference the underlying map. Done means off-screen locations can be converted for bridging elements without removing the existing bounded behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile-dev
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100