mapbox / mapbox/mapbox-maps-ios

Add new GestureManagerDelegate method to track gesture progress

Open
#1,100 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

auto-triaged feature :green_apple:
Dominant language
Swift
Stars
601
Forks
196
PR merge metrics
No merged PRs in 30d

Description

## New Feature

We encountered problem that we cannot adjust or track gesture while it is in progress as we cannot track it. We suggest to add new method `func gestureManager(_ gestureManager: GestureManager, didChange gestureType: GestureType)`. It will allow to track gesture progress and update other views or map, if we want specific behaviour like zoom only to centre.

## Why
In mapbox 6 there was "regionIsChanging" delegate which we used and anchorPoint method for gestures where we could adjust centre point when user performs a gesture. In new version there no such methods or they are not as obvious to use. We need this, for example, to update angle slider when user rotate map with pinch gesture and also to update map centre while zooming with pinch so map won't move (forbid pan gesture while zooming)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating GestureManagerDelegate and the existing GestureManager and GestureType gesture callbacks. Determine how a progress-change callback should report pinch and rotation updates, then verify that consumers can use it to update views or the map center while a gesture is active.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.