mapbox / mapbox/mapbox-maps-flutter

Crash on Android when calling [queryRenderedFeatures]

Open
#933 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Dart
Stars
380
Forks
204
PR merge metrics
No merged PRs in 30d

Description

Android SDK causes a crash whenever [queryRenderedFeatures] is called and the data is corrupted.
Corruption ticket created in mapbox android repository -> https://github.com/mapbox/mapbox-maps-android/issues/2619

### Reason
GSON cannot jsonify Infinity and NAN floating numbers. Which results in the following line crashing:
```kotlin
fun com.mapbox.maps.QueriedFeature.toFLTQueriedFeature(): QueriedFeature {
return QueriedFeature(JSONObject(this.feature.toJson()).toMap(), source, sourceLayer, state.toJson())
}
```

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the toFLTQueriedFeature conversion shown in the issue and trace how queryRenderedFeatures reaches it. Read the linked Android corruption ticket for the affected data case, then reproduce the crash with corrupted data. Done means queryRenderedFeatures no longer crashes when Infinity or NaN values are present.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, dart, flutter, kotlin
Domain
mobile-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.