mapbox / mapbox/mapbox-maps-flutter

API v2 with turf conflicts with internal Mapbox classes

Open
#606 1 comment 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Dart
Stars
380
Forks
204
PR merge metrics
No merged PRs in 30d

Description

I have migrated from v1 to v2 and now I have class mismatch errors all over the place.

Look like Mapbox sdk is having it's own Point class that extends turf Point. Which is fine I guess.

But the issue is that if I use FeatureCollection.fromJson(jsonDecode(data) as Map<String, dynamic>); as FeatureCollection is not a class from Mapbox but from (geotype but let's say turf) then when I try to to pass this featureCollection back to Mapbox is fails with the following error:

type 'Point' is not a subtype of type 'Point' in type cast where
  Point is from package:geotypes/src/geojson.dart
  Point is from package:mapbox_maps_flutter/mapbox_maps_flutter.dart

v2 is currently not usable to me.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the v1-to-v2 migration context and reproduce the failure using FeatureCollection.fromJson(jsonDecode(data) as Map<String, dynamic>). Trace the two Point types shown in the error across geotypes and mapbox_maps_flutter, and consider the issue done when a decoded FeatureCollection can be passed back to Mapbox without the type-cast conflict.

Written by the indexing model from the issue text.

Assessment

Tech stack
dart, flutter
Domain
mobile-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.