mapbox / mapbox/mapbox-maps-android

MapDelegateProvider incorrectly restricted to library scope

Open
#2,577 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

auto-triaged bug :beetle:
Dominant language
Kotlin
Stars
578
Forks
161
PR merge metrics
No merged PRs in 30d

Description

## Environment

- Android OS version: does not apply
- Devices affected: does not apply
- Maps SDK Version: since 11.1.0 to now (11.10.0)

## Observed behavior and steps to reproduce

When implementing `com.mapbox.maps.plugin.MapPlugin` interface, Android Studio shows a lint error. This occurs because the interface depends on `com.mapbox.maps.plugin.delegates.MapDelegateProvider`, which was restricted to library scope in commit https://github.com/mapbox/mapbox-maps-android/commit/78ff1f884ca5038916b93f5c89f1c1aa36307393

## Expected behavior

`MapDelegateProvider` should be publicly accessible since the documentation of `com.mapbox.maps.plugin.Plugin` specifies that the `MapPlugin` interface is designed to support user-defined plugins.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading MapDelegateProvider, MapPlugin, and the referenced commit that restricted the provider to library scope. Verify the public API and lint behavior for a user-defined MapPlugin; done means MapDelegateProvider is publicly accessible as required by the Plugin documentation.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
api, mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.