Use unrecognised properties of RouteOptions for requests via MapboxDirections
Open
Nobody has claimed this yet.
jira-sync-complete
- Dominant language
- Java
- Stars
- 438
- Forks
- 117
- PR merge metrics
- No merged PRs in 30d
Description
Unrecognised properties of RouteOptions are used only in RouteOptions.toUrl(). Unrecognised properties are ignored if you do request via MapboxDirections:
val client = MapboxDirections.builder().accessToken(getMapboxAccessTokenFromResources()).routeOptions(routeOptions).build()
client.enqueueCall(object : Callback<DirectionsResponse> {
override fun onResponse(
call: Call<DirectionsResponse>,
response: Response<DirectionsResponse>
) {
Log.d(TAG, "onResponse: what")
if (response.isSuccessful) {
Log.d(TAG, "onResponse: hello")
val body = response.body()!!
mapboxNavigation.setRoutes(body.routes())
Log.d(TAG, "onResponse: ${body.routes()}")
}
}
override fun onFailure(call: Call<DirectionsResponse>, t: Throwable) {}
})
Add support of unrecognised properties from RouteOptions to MapboxDirections
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue points to RouteOptions.toUrl() and the MapboxDirections.builder().routeOptions(...) request path; read those entry points first. Verify how unrecognised properties are handled and ensure requests built through MapboxDirections include them, matching the direct RouteOptions URL behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, kotlin
- Domain
- api
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100