mapbox / mapbox/mapbox-gl-js

turning-feature pulsating on zoom out z17->z16

Open
#9,777 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug :lady_beetle:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

![Jun-10-2020 20-30-18](https://user-images.githubusercontent.com/549216/84299342-3eaa2b00-ab59-11ea-99b8-bd3377489b00.gif)

Zoom 17 tiles are kept for fading by source_cache, see `tile.holdingForFade()` and rendered over Z16 circle (which is fading in like other symbols).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the zoom transition described in the issue and inspect source_cache together with tile.holdingForFade(). Reproduce the z17-to-z16 transition using the attached animation, then trace why the retained z17 tiles render over the fading z16 circle. Done means the turning feature no longer pulsates during this zoom transition.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.