Simplify geometry loading when populating bucket features
Open
@zmiao is already working on this.
Since Mar 11, 2020.
refactoring :building_construction:
- Dominant language
- TypeScript
- Stars
- 12.4k
- Forks
- 2.4k
- PR merge metrics
- No merged PRs in 30d
Description
An extra step of loading geometry and generating a temporary feature was introduced in https://github.com/mapbox/mapbox-gl-js/pull/9352, the purpose of it is that valid geometries need to come along with the feature in case within expression is used inside the filter.
Based on comment https://github.com/mapbox/mapbox-gl-js/pull/9352#discussion_r389721693, geometry loading could be handled in a cleaner way and canonical value could be passed along with the feature.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.