mapbox / mapbox/mapbox-gl-js

Reintroduce feature "Hide glyphs behind the camera"

Open
#9,334 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature :green_apple:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

https://github.com/mapbox/mapbox-gl-js/commit/1eed2ae8290f5a069284958708787bc2159e329f commit from https://github.com/mapbox/mapbox-gl-js/pull/9229 was reverted because of some potential driver issues on windows machine (reproduced on Intel Haswell chip), refer https://github.com/mapbox/mapbox-gl-js/issues/9327 and https://github.com/mapbox/mapbox-gl-js/pull/9333.

Now that we have a repro we should be able to pinpoint the problem and reintroduce the feature appropriately.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the reverted commit 1eed2ae and the discussion in issue 9327 and pull request 9333 first. Reproduce the Windows driver problem on the Intel Haswell setup described there, then determine how the feature can be reintroduced without that failure; completion requires the feature to work and the reported driver issue to be resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
computer-graphics
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.