Map.panBy and Point.convert API
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 12.4k
- Forks
- 2.4k
- PR merge metrics
- No merged PRs in 30d
Description
`map.panBy` specifies that its first argument can be a `PointLike` object. Though if you pass in an `{x, y}` literal it fails in `camera.js` due to the ```Point.convert(offset).mult()``` call that assumes that the output from `Point.convert` is a real Point instance, which is not what `Point.convert` spec actually says, it will only convert Array to Point, other objects (literals) unchanged.
/Fredrik Blomqvist
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in camera.js at map.panBy and inspect the Point.convert(offset).mult() call, then compare it with the Point.convert API behavior described in the issue. Reproduce the failure with an {x, y} offset and verify that map.panBy accepts the documented PointLike input without throwing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100