`icon-text-fit-padding` produces inconsistent pixel padding
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 12.4k
- Forks
- 2.4k
- PR merge metrics
- No merged PRs in 30d
Description
I'm using two icons that are identical in dimensions. Here's an example of the first:
```svg
```
On duplicate layers to create an outline effect by setting the `icon-text-fit-padding` values to be 1 pixel larger than the second . But the pixels appear inconsistent in cases
---
**mapbox-gl-js version**: `v1.1.0`
**browser**: `Google Chrome Version 74.0.3729.169 (Official Build) (64-bit)`
### Expected behavior
I would expect the value of `icon-text-fit-padding` in the first layer to be evenly padded by 1 additional pixels
### Link to Demonstration
https://jsfiddle.net/s1fxmvn2/embedded/result/?username=tristen
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the inconsistent padding in the linked JSFiddle using mapbox-gl-js v1.1.0 and the duplicate icon layers described in the issue. Trace the implementation of `icon-text-fit-padding` from that example and compare the rendered pixels for identical icons. Done means a one-pixel increase produces even padding in the reported cases, with coverage for the regression.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100