mapbox / mapbox/mapbox-gl-js

is "will-change" property really required for marker?

Open
#8,267 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

performance :zap:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

`will-change: transform` style on `.mapboxgl-marker` causes blurry text. Unless this really matter with performance, what about to remove this?
with/without:
![image](https://user-images.githubusercontent.com/7428017/58083349-caba7f00-7bf3-11e9-829d-d463eaca2f14.png) ![image](https://user-images.githubusercontent.com/7428017/58083364-d27a2380-7bf3-11e9-8653-87ca437cc54b.png)

toggle `will-change: transform` here: https://jsfiddle.net/cs09g/tzcryxm0/8/
FYI, will-change on MDN: https://developer.mozilla.org/en-US/docs/Web/CSS/will-change

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the `.mapboxgl-marker` style that applies `will-change: transform`, then compare the marker rendering with and without that declaration using the linked JSFiddle as a reproduction. Done means the blurry-text behavior and any relevant performance impact are understood, with the issue’s proposed CSS change validated against the reproduction.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, typescript
Domain
frontend, performance
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.