Symbol interpolation issue when icon-pitch-alignment is "map"
Open
Nobody has claimed this yet.
bug :lady_beetle:
good first issue
- Dominant language
- TypeScript
- Stars
- 12.4k
- Forks
- 2.4k
- PR merge metrics
- No merged PRs in 30d
Description
mapbox-gl-js version: v0.54.0-beta.1
browser: any
Steps to Trigger Behavior
- create a symbol layer with icon-pitch-alignment set to "map"
- do not rotate or pitch the map
Expected Behavior
Icon should be rendered with NEAREST interpolation
Actual Behavior
Icon is rendered with LINEAR interpolation
Hint: there is a condition in draw_symbol.js:197
pitchWithMap || tr.pitch !== 0
I think it should be just
tr.pitch !== 0
because when icon-pitch-alignment is set to "map", and neither the icon nor the map is rotated, NEAREST should be used. (same as "viewport" alignment)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at draw_symbol.js:197 and reproduce the issue with a symbol layer using icon-pitch-alignment set to "map" without rotating or pitching the map. Compare the interpolation behavior with viewport alignment; done means the map-aligned icon uses NEAREST interpolation under these conditions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100