mapbox / mapbox/mapbox-gl-js

turnstile unit test is flaky around midnight gmt

Open
#7,698 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug :lady_beetle:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

https://github.com/mapbox/mapbox-gl-js/blob/b235bb755707a7e9c72a755df0b8c6991c11f5bf/test/unit/util/mapbox.test.js#L521-L539

Around midnight gmt the two times are during different days and this test fails.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with test/unit/util/mapbox.test.js at lines 521-539 and inspect the turnstile unit test's handling of the two times. Reproduce the failure around midnight GMT, then verify that the test passes when the times fall on different days without changing the intended behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.