mapbox / mapbox/mapbox-gl-js

Use style-spec ExpressionParameter to validate style expressions

Open
#7,382 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

refactoring :building_construction:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

Reuse the style specs documentation for validation, enforcing a single point of truth for what is and isn't a valid style.
Validate property and filter expressions using the ExpressionParameter to determine the permitted expression types.

Pulled from #7366(comment)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the style specs documentation and the existing validation paths for property and filter expressions, focusing on how ExpressionParameter determines permitted expression types. Done means both expression kinds use the style-spec definitions as their single validation source, without separate conflicting rules.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.