mapbox / mapbox/mapbox-gl-js

performance regression for filter evaluation

Open
#7,322 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

performance :zap:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

there has been a regression in filter evaluation performance since https://github.com/mapbox/mapbox-gl-js/pull/5665 – we accepted an initial performance hit (~0.2ms -> ~0.6ms) as part of eliminating `unsafe-eval` requirement, but there seems to have been further degradation since that change.

![image](https://user-images.githubusercontent.com/2425307/45896335-aff3ea00-bd88-11e8-8a5c-6607d3e02c1f.png)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing pull request #5665 and the linked performance image to understand the accepted baseline and the later regression. Locate the current filter-evaluation path and establish a repeatable performance comparison; done means identifying the source of the additional degradation and confirming the evaluation time no longer exceeds the intended baseline.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.