mapbox / mapbox/mapbox-gl-js

Remove all Flow library definitions from flow-typed/

Open
#7,035 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

workflow :nail_care:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

https://github.com/mapbox/mapbox-gl-js/pull/7031 moves type definitions that are local to this project out of `flow-typed` and into `src`, so that they must be imported explicitly. Following up on that, we should remove the remaining libdefs as well as a step towards #6963. (Necessary because in a downstream project, Flow would not look for libdefs in our flow-typed/ directory.)

- [ ] mapbox-gl-supported.js https://github.com/mapbox/mapbox-gl-supported/pull/21
- [ ] mapbox-unitbezier.js https://github.com/mapbox/unitbezier/pull/2
- [ ] pbf.js https://github.com/mapbox/pbf/pull/91
- [ ] point-geometry.js
- [ ] shelf-pack.js
- [ ] unitbezier.js
- [ ] vector-tile.js

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the remaining definitions in flow-typed/: mapbox-gl-supported.js, mapbox-unitbezier.js, pbf.js, point-geometry.js, shelf-pack.js, unitbezier.js, and vector-tile.js. Review the referenced upstream pull requests and issue #6963, then remove the remaining libdefs once their definitions are available in the intended locations; done means no remaining library definitions stay under flow-typed/.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.