mapbox / mapbox/mapbox-gl-js

map.on click not firing any more on shift+click

Open
#6,971 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug :lady_beetle: environment-specific :desktop_computer:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

**mapbox-gl-js version**:
v0.46.0
**browser**:
Firefox 61.0.1 (64-Bit)
Safari version 11.1.1 (13605.2.8)
Chrome Version 67.0.3396.99 (Official Build) (64-bit)

### Steps to Trigger Behavior

1. register a map on click event
2. shift+click or ctrl+click on the map like so map.on('click', function(e)...

### Link to Demonstration

### Expected Behavior
same in all browsers

### Actual Behavior
* not working (any more) in Firefox and Google Chrome (event is not fired on ctrl-click and shift-click, but it is fired for metaKey+click and alt-key and click.
* not workingin Safari (shift+click is not firing the event, the other modifiers including ctrl-click work as expected)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the map.on('click') behavior with shift+click and ctrl+click in Firefox, Safari, and Chrome using the reported versions or current equivalents. Compare modifier-key behavior across browsers; done means click events fire consistently for the reported modifiers without breaking the existing metaKey and alt-key behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.