npm install breaks tests
Nobody has claimed this yet.
- #10948 by @ryanhamley — closed without merging
- Dominant language
- TypeScript
- Stars
- 12.4k
- Forks
- 2.4k
- PR merge metrics
- No merged PRs in 30d
Description
**mapbox-gl-js version**: 0.45.0
### Steps to Trigger Behavior
1. `npm install`
2. `yarn test`
### Expected Behavior
`npm install` and `yarn install` will produce the same output so that all tests will pass correctly
### Actual Behavior
`npm install` bypasses the `yarn.lock` file and installs a newer version of `@mapbox/batfish` that breaks some tests.
### Possible solution
set up `npm install` to fallback to yarn with the [`use-yarn` node module](https://www.npmjs.com/package/use-yarn)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running `npm install` followed by `yarn test`, then compare the result with `yarn install` followed by `yarn test`. Read the package-manager setup and the `use-yarn` module documentation mentioned in the issue. Done means npm installation follows the project’s locked dependency behavior and the tests pass consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- node.js
- Domain
- build-system, testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100