mapbox / mapbox/mapbox-gl-js

Introduce additional code style rules from eslint-plugin-import

Open
#6,294 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

refactoring :building_construction: workflow :nail_care:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

Following up on https://github.com/mapbox/mapbox-gl-js/pull/6196 (keeping this separate to reduce noise in that monster PR), I think we should add the following rules from https://github.com/benmosher/eslint-plugin-import#style-guide:

- first
- exports-last
- order
- newline-after-import
- prefer-default-export

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review pull request #6196 and the eslint-plugin-import style guide first, then locate the repository's ESLint configuration and assess the five listed rules. The work is done when those rules are enabled and the project's lint checks pass without unresolved violations.

Written by the indexing model from the issue text.

Assessment

Tech stack
eslint, javascript, typescript
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.