mapbox / mapbox/mapbox-gl-js

Consider hillshade-opacity property

Open
#5,935 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

needs discussion :speech_balloon:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

It's a bit surprising that there is no `hillshade-opacity` property. I think it's the only layer type that doesn't have one. Currently the workaround is to use `hsla` or `rgba` colors with the alpha channel.

OTOH, maybe that becomes confusing, because I guess properties like `hillshade-shadow-color` are implicitly mixing the given color in varying degrees of alpha across the layer.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how existing hillshade properties, especially hillshade-shadow-color, are defined and rendered, then compare them with opacity properties on other layer types. Clarify whether hillshade-opacity should control overall visibility or interact with color alpha, and consider the associated style validation, rendering behavior, and tests before defining done.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
computer-graphics, frontend, web-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.