Do not handle video loading errors
Open
Nobody has claimed this yet.
api :memo:
good first issue
- Dominant language
- TypeScript
- Stars
- 12.4k
- Forks
- 2.4k
- PR merge metrics
- No merged PRs in 30d
Description
In src/util/ajax.js, getVideo seems not handle any loading errors.
And Also, I think it's useless to return video in the end. We should get video in callback.
https://github.com/mapbox/mapbox-gl-js/blob/master/src/util/ajax.js#L149
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading getVideo in src/util/ajax.js around the linked line to understand its current loading and callback behavior. The work is done when video loading errors are handled through the callback and the function's return behavior matches the intended callback-based API.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100