mapbox / mapbox/mapbox-gl-js

Add render tests for light

Open
#5,629 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

testing :100:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

It doesn't look like we have any tests for the effects of [light](https://www.mapbox.com/mapbox-gl-js/style-spec/#light) properties. We should add some, including the use of data-driven manipulation and expressions.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the existing render tests for other style properties and compare how they cover data-driven manipulation and expressions. Run the relevant render-test suite first; the work is done when light properties have equivalent coverage for those cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
computer-graphics, testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.