mapbox / mapbox/mapbox-gl-js

Convert feature_index.js to use new 'grid-index'

Open
#5,505 1 comment 0 reactions 1 assignee View on GitHub

@ChrisLoer is already working on this.

Since Oct 23, 2017.

refactoring :building_construction:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

#5150 updated `grid-index` to be circle-aware, and pulled it into the main repo. However, I missed that `feature_index.js` was also using `grid-index`, and it's still puling the old version from https://github.com/mapbox/grid-index.

We should switch to using the same interface so we're not pulling in two copies of such similar code.

/cc @ansis

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.