Take offsets into account when placing popups
Open
Nobody has claimed this yet.
bug :lady_beetle:
- Dominant language
- TypeScript
- Stars
- 12.4k
- Forks
- 2.4k
- PR merge metrics
- No merged PRs in 30d
Description
We currently pivot popups around the marker such that it never gets cut off the edge of the viewport. However, this calculation is done assuming no x-y offsets are applied, which does result in cutoffs. We should take offsets into account for this.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the popup placement calculation that pivots popups around markers and inspect how x-y offsets are applied. Verify the placement logic with offset values and confirm that the popup remains inside the viewport without being cut off.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100