Port Render* split and immutability from native
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 12.4k
- Forks
- 2.4k
- PR merge metrics
- No merged PRs in 30d
Description
We should replace the current smart `setStyle` implementation in gl-js with one more similar to native, based on a split between:
* immutable, pure style-spec domain objects, independent of rendering, and
* parallel `Render*` objects that handle rendering-specific concerns and can update themselves by diffing prior and new immutable objects
This approach eliminates the complex state tracking needed to track "pending" changes (`Style#_updatedLayers`, `_updatedSymbolOrder`, `_updatedSources`, etc.).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the current smart setStyle implementation in gl-js, including Style#_updatedLayers, _updatedSymbolOrder, and _updatedSources, then compare it with the native approach referenced in the issue. Done means replacing the pending-change state tracking with immutable style-spec objects and parallel Render* objects that update by diffing old and new objects.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100