mapbox / mapbox/mapbox-gl-js

stop camera animation when constrained by maxBounds

Open
#4,872 9 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug :lady_beetle:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

When using `flyTo` with a `maxBounds` set on the map, the camera will keep trying to animate when hitting the bounds.

https://jsbin.com/ritikupaqe/edit?html,output

Should we change this so that when the transform becomes constrained, the animation is stopped at that point?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked JSBin reproduction and trace the flyTo camera animation as maxBounds constrains the transform. Confirm the current repeated animation behavior, then identify the relevant camera and transform entry points; the work is done when the animation stops at the constraint and the behavior is covered by an appropriate regression check.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.