mapbox / mapbox/mapbox-gl-js

Add updateImage API, or allow addImage to update

Open
#4,804 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

api :memo: bug :lady_beetle:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

There's currently no API for updating the image associated with a particular ID. gl-native allows updating an image via `addImage`, but in gl-js that triggers an error.

When implementing this, care should be taken to avoid the gl-js equivalents of https://github.com/mapbox/mapbox-gl-native/issues/6536 and https://github.com/mapbox/mapbox-gl-native/issues/7618.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the existing gl-js addImage API and review the two linked gl-native issues before choosing between an updateImage API and allowing addImage to replace an image. Done means updates for an existing ID work without reproducing the cited native issues, while the current error behavior is covered by the relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.