mapbox / mapbox/mapbox-gl-js

Event cleanup master ticket

Open
#4,253 2 comments 11 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

api :memo: refactoring :building_construction:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

I'm working on hitting some of the open issues that have to do with our eventing system, and I'm opening this ticket to keep track of those issues:

- [x] Debug `MapDataEvent#isSourceLoaded` #3958 👉 #4254
- [x] refactor `sourcedata` and deprecate `tiledata` events ✅ #4347
- [x] Debug `Map#loaded` #3950
- [x] Add methods to check loaded status of Map resources #3691 👉 #4033 ✅, still need `Map#isStyleLoaded` and `Map#isTileLoaded`
- [ ] deprecate `source.load` ✅ #4347, `style.load`, etc #3970
- [x] Add `mouseover` event #3217
- [x] Add `pitchstart` + `pitchend` events #2449 👉 #4473
- [ ] Add `datastart` + `dataend` events: https://github.com/mapbox/mapbox-gl-js/issues/1715#issuecomment-249293404
- [ ] differentiate 'interaction' events and 'camera' camera events #3357
- [x] figure out passive event listeners for touch devices #3720 #4259 👉 #4487 ✅

If there are other event related tickets I've missed please comment here!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the remaining unchecked checklist items and their linked issues, especially #3970, #1715, and #3357, before choosing a specific task. The master ticket is complete when the selected eventing work is implemented and its corresponding issue is resolved; this ticket does not identify files or tests to start from.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.