mapbox / mapbox/mapbox-gl-js

Convert validation test fixtures to normal tests

Open
#4,197 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

testing :100:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

The fixtures used for testing the validator make it hard to be sure you aren't introducing unintended changes, because a change to the input can change many lines of the output as line and layer numbers are adjusted. They also separate the test input from the expected output, making intended behavior harder to read.

We should convert all the fixtures to regular tap and assertion-based tests.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the validator fixtures and the tests that consume them, then read how those tests currently load input and expected output. Done means all fixtures are replaced by regular TAP and assertion-based tests while preserving the intended validator behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
testing-qa
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.