mapbox / mapbox/mapbox-gl-js

Please add SDF support for fill-pattern

Open
#4,184 4 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

cross-platform :tv: feature :green_apple:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

`fill-pattern` property currently ignores sdf property in sprite json definition. It'd be extremely handy to use SDF icons for fill-patterns, so `fill-color` and `fill-opacity` could be used along with it, like sdf icons for symbol layers.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the fill-pattern handling and the existing SDF path for symbol layers, then compare how sprite JSON properties are interpreted in each path. Done means SDF icons used as fill patterns honor fill-color and fill-opacity in the same usable way as SDF icons for symbol layers; verify the behavior with the relevant rendering tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
computer-graphics
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.