Validator should prohibit use of source-layer for GeoJSON sourced layers
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 12.4k
- Forks
- 2.4k
- PR merge metrics
- No merged PRs in 30d
Description
_From @jfirebaugh on December 11, 2016 1:45_
`source-layer` should be prohibited for layers whose source is a GeoJSON layer, not merely ignored, or in the example of https://github.com/mapbox/mapbox-gl-js/issues/3779, used in a way that prevents the layer from displaying at all.
Marking this as v9 as it would be an increase in strictness that that's likely to affect existing styles, including ones used with the current styles API.
_Copied from original issue: mapbox/mapbox-gl-style-spec#620_
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the style validator responsible for checking layer properties and the handling of GeoJSON sources. Confirm how source-layer is treated for GeoJSON-sourced layers, then add validation coverage showing that its use is prohibited rather than ignored. Done means the validator rejects this combination without changing unrelated layer validation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100